sys/socket.h: define SOL_IPV6?

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

sys/socket.h: define SOL_IPV6?

Yaakov (Cygwin/X)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Does it make sense to define SOL_IPV6 now?  Patch attached if so.


Yaakov
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEAREIAAYFAkn1JN8ACgkQpiWmPGlmQSNx6gCeIIaTkZ1JfkQQ95mJoUtJNBXl
z58AoPudyZ7Xo0yxwggJEwLJEE9UMT9V
=qIUQ
-----END PGP SIGNATURE-----

2009-04-26  Yaakov Selkowitz  <[hidden email]>

        * include/cygwin/socket.h: Define SOL_IPV6.


Index: include/cygwin/socket.h
===================================================================
RCS file: /cvs/src/src/winsup/cygwin/include/cygwin/socket.h,v
retrieving revision 1.26
diff -u -r1.26 socket.h
--- include/cygwin/socket.h 9 Mar 2009 14:40:45 -0000 1.26
+++ include/cygwin/socket.h 27 Apr 2009 03:17:54 -0000
@@ -198,6 +198,7 @@
 
 /* Setsockoptions(2) level. Thanks to BSD these must match IPPROTO_xxx */
 #define SOL_IP 0
+#define SOL_IPV6 41
 #define SOL_IPX 256
 #define SOL_AX25 257
 #define SOL_ATALK 258
Reply | Threaded
Open this post in threaded view
|

Re: sys/socket.h: define SOL_IPV6?

Christopher Faylor-8
On Sun, Apr 26, 2009 at 10:22:07PM -0500, Yaakov (Cygwin/X) wrote:
>Does it make sense to define SOL_IPV6 now?  Patch attached if so.

I think it does.  I've checked in this patch.  I'm sure Corinna will
revert it if I am wrong.

Thanks.

cgf
Reply | Threaded
Open this post in threaded view
|

Re: sys/socket.h: define SOL_IPV6?

Corinna Vinschen-2
On Apr 27 00:31, Christopher Faylor wrote:
> On Sun, Apr 26, 2009 at 10:22:07PM -0500, Yaakov (Cygwin/X) wrote:
> >Does it make sense to define SOL_IPV6 now?  Patch attached if so.
>
> I think it does.  I've checked in this patch.  I'm sure Corinna will
> revert it if I am wrong.

It's not wrong but unfortunately it won't help either.  The only SOL_xxx
option supported by Winsock is SOL_SOCKET.  But since we already have
the other SOL_xxx options defined, it's a good idea to have SOL_IPV6
defined as well.


Corinna

--
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat