qmake-qt5 does not support QMAKE_POST_LINK on shared object targets

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

qmake-qt5 does not support QMAKE_POST_LINK on shared object targets

matthias
Dear qt5-base maintainers,

I noticed that QMAKE_POST_LINK is not applied to shared object targets  
in qmake (version 3.1 from Qt 5.9.4). The purpose of QMAKE_POST_LINK  
is to add custom script statements after the link step in  
qmake-generated Makefiles.

I checked cygwin's package files for qt5-base and found this patch  
which IMHO is lacking QMAKE_POST_LINK support.

The qmake.patch is taken from here:

https://cygwin.com/git-cygwin-packages/?p=git/cygwin-packages/qt5-base.git;a=blob;f=5.9-cygwin-qmake.patch;h=e6feef3d3a19e5e412adf6e4f2b9ac512553cdc1;hb=HEAD

I am referring to this part of the qmake.patch file:

   72              if (!isystem.isEmpty() && isSystemInclude(inc.toQString()))
   73 @@ -603,6 +603,14 @@ UnixMakefileGenerator::writeMakeParts(QT
   74              if(!project->isEmpty("QMAKE_POST_LINK"))
   75                  t << "\n\t" << var("QMAKE_POST_LINK");
   76              t << endl << endl;
   77 +        } else if(!project->isEmpty("QMAKE_CYGWIN_SHLIB")) {
   78 +            t << "\n\t"
   79 +              << "-$(DEL_FILE) $(TARGET) $(TARGET0)" << "\n\t"
   80 +              << var("QMAKE_LINK_SHLIB_CMD") << "\n\t";
   81 +            if(!destdir.isEmpty())
   82 +              t  << "-$(DEL_FILE) " << destdir << "$(TARGET)\n\t"
   83 +                 << "-$(DEL_FILE) " << destdir << "$(TARGET0)\n\t"
   84 +                 << "-$(MOVE) $(TARGET) $(TARGET0) " << destdir;
----
# IMHO this part of the patch is missing to enable QMAKE_POST_LINK:
                   if(!project->isEmpty("QMAKE_POST_LINK"))
                       t << "\n\t" << var("QMAKE_POST_LINK");
                   t << endl << endl;
----
   85          } else if(project->isEmpty("QMAKE_HPUX_SHLIB")) {
   86              t << "\n\t";
   87


Thanks for considering this bug report.

Best regards,

Matthias

-----Original Message-----
From: Gratz Achim (IFD PMM TI ICTD) <[hidden email]>
Sent: Dienstag, 25. Februar 2020 09:26
To: Koefferlein Matthias (IFAG DES TCP FLP)  
<[hidden email]>
Subject: RE: KLayout cygwin build

Hallo Matthias,

> Ok, verstehe. Dann ist der execinfo-Patch auch eine Lösung - es geht
> ja nur um den crash handler.

Genauer um den Stacktrace.

> Das build-Skript macht eigentlich ja nicht viel. Wenn Du die Variablen
> selber definierst, kannst Du den qmake auch direkt aufrufen. Sind aber
> halt eine Menge Variablen.

Ich krieg' das schon hin, ich muß es ja normalerweise nur einmal durchturnen.

> Ich bekomme übrigens ein:
>
> fatal: repository
> 'https://cygwin.com/git-cygwin-packages/?p=git/cygwin-
> packages/qt5-base.git/' not found
>
> :(

Probier's nochmal, irgendjemand scheint gerade den Sourceware-Server zu DOSen.


Mit freundlichen Grüßen.
--
mailto:[hidden email]
HV-CMOS Technology Development and Process Integration
Office: +49 351 886 17 84    Fax: +49 351 886 84 17 84

Infineon Technologies Dresden GmbH & Co. KG Sitz der Gesellschaft: Dresden
Registergericht: Dresden HRA 10404

Persönlich haftende Gesellschafterin: Infineon Technologies Dresden  
Verwaltungs GmbH Vorsitzender des Aufsichtsrats: Pantelis Haidas
Geschäftsführer: Dr. Rutger Wijburg, Raik Brettschneider Sitz der  
Gesellschaft: Neubiberg
Registergericht: München HRB 229585

----- Ende der weitergeleiteten Nachricht -----



--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple