adopt and update libatomic_ops and libgc

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

adopt and update libatomic_ops and libgc

Andy Li
Hi,

I would like to adopt and update the now orphaned libatomic_ops and
libgc packages, which is a dependency of the neko package I
maintained.

The updated cygport files can be found at:
https://github.com/andyli/libatomic_ops-cygwin
https://github.com/andyli/libgc-cygwin

Note that I've split them into separated packages, since the source of
libgc no longer contains a copy of atomic_ops, and they are versioned
independently as well.

Please review and let me know if there is anything to improve.

Best regards,
Andy
Reply | Threaded
Open this post in threaded view
|

Re: adopt and update libatomic_ops and libgc

Brian Inglis
On 2017-05-08 05:54, Jon Turney wrote:

> On 07/05/2017 13:41, Andy Li wrote:
>> I would like to adopt and update the now orphaned libatomic_ops
>> and libgc packages, which is a dependency of the neko package I
>> maintained.
>> The updated cygport files can be found at:
>> https://github.com/andyli/libatomic_ops-cygwin
>> https://github.com/andyli/libgc-cygwin
>> Note that I've split them into separated packages, since the source
>> of libgc no longer contains a copy of atomic_ops, and they are
>> versioned independently as well.
>> Please review and let me know if there is anything to improve.
> Thanks.
> libatomic_ops.cygport:
> A comment that we need to correct for this installing it's
> documentation into usr/share/libatomic_ops, rather that
> usr/share/doc/libatomic_ops might be nice.
> This could alternatively be written using a custom src_install which
> calls cyginstall then moves the directory, which might be less
> brittle to changes in the file list?
> This might be an upstream defect if it doesn't respect --docdir?
> libgc.cygport:
> DEPEND might be better written pkgconfig(atomic_ops)
> Again, stuff installed to usr/share/gc/ should probably be moved to
> usr/share/doc/gc
> I note we also have libgc-7.2d-2 as non-source package, which just
> contains usr/share/doc/Cygwin/libgc.README. That probably needs to
> be cleaned up by being obsoleted.

[was this intended for cygwin-apps?]

--
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada
Reply | Threaded
Open this post in threaded view
|

Re: adopt and update libatomic_ops and libgc

Andy Li
> On 2017-05-08 05:54, Jon Turney wrote:
>> libatomic_ops.cygport:
>> A comment that we need to correct for this installing it's
>> documentation into usr/share/libatomic_ops, rather that
>> usr/share/doc/libatomic_ops might be nice.
>> This could alternatively be written using a custom src_install which
>> calls cyginstall then moves the directory, which might be less
>> brittle to changes in the file list?
>> This might be an upstream defect if it doesn't respect --docdir?

Right, I've just sent a PR to the upstream to fix it. See
https://github.com/ivmai/libatomic_ops/pull/25
I've included it as a patch in the cygport file, which we can remove
in the next version if the PR is merged.

>> libgc.cygport:
>> DEPEND might be better written pkgconfig(atomic_ops)
>> Again, stuff installed to usr/share/gc/ should probably be moved to
>> usr/share/doc/gc

Similarly, the PR: https://github.com/ivmai/bdwgc/pull/161

>> I note we also have libgc-7.2d-2 as non-source package, which just
>> contains usr/share/doc/Cygwin/libgc.README. That probably needs to
>> be cleaned up by being obsoleted.

What is the procedure of obsoleting packages?

Best regards,
Andy
Reply | Threaded
Open this post in threaded view
|

Re: adopt and update libatomic_ops and libgc

Jon TURNEY
On 09/05/2017 06:59, Andy Li wrote:

>> On 2017-05-08 05:54, Jon Turney wrote:
>>> libatomic_ops.cygport:
>>> A comment that we need to correct for this installing it's
>>> documentation into usr/share/libatomic_ops, rather that
>>> usr/share/doc/libatomic_ops might be nice.
>>> This could alternatively be written using a custom src_install which
>>> calls cyginstall then moves the directory, which might be less
>>> brittle to changes in the file list?
>>> This might be an upstream defect if it doesn't respect --docdir?
>
> Right, I've just sent a PR to the upstream to fix it. See
> https://github.com/ivmai/libatomic_ops/pull/25
> I've included it as a patch in the cygport file, which we can remove
> in the next version if the PR is merged.
>
>>> libgc.cygport:
>>> DEPEND might be better written pkgconfig(atomic_ops)
>>> Again, stuff installed to usr/share/gc/ should probably be moved to
>>> usr/share/doc/gc
>
> Similarly, the PR: https://github.com/ivmai/bdwgc/pull/161
>
>>> I note we also have libgc-7.2d-2 as non-source package, which just
>>> contains usr/share/doc/Cygwin/libgc.README. That probably needs to
>>> be cleaned up by being obsoleted.
>
> What is the procedure of obsoleting packages?

In this case I think you just need:

libgc_devel_OBSOLETES="libgc"

(See https://cygwinports.github.io/cygport/pkg_pkg_cygpart.html#robo445)

I added libatomic_ops and libgc to your package list.

Reply | Threaded
Open this post in threaded view
|

Re: adopt and update libatomic_ops and libgc

Andrew Schulman
> I added libatomic_ops and libgc to your package list.

Gold stars awarded! https://cygwin.com/goldstars/#AL

Reply | Threaded
Open this post in threaded view
|

Re: adopt and update libatomic_ops and libgc

Andy Li
Oh, that was unexpected! Thank you :D

Best,
Andy

On Thu, May 11, 2017 at 10:27 PM, Andrew Schulman
<[hidden email]> wrote:
>> I added libatomic_ops and libgc to your package list.
>
> Gold stars awarded! https://cygwin.com/goldstars/#AL
>