Re [Cygwin PATCH */9] tzcode resync -- for discussion only

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re [Cygwin PATCH */9] tzcode resync -- for discussion only

Mark Geisert
I'm not absolutely sure yet but I think this patch set isn't complete.
What's been posted is OK for discussion (on cygwin-developers?) but would
need to be augmented if you're going to apply as-is.

I had a git commit/revert mishap and these are recovered file versions.  I
belatedly discovered there's no record in the patches of my creating
directory winsup/cygwin/tzcode or of my deleting localtime.cc and
tz_posixrules.h from winsup/cygwin in my local repository.

When it becomes time to submit the final patch versions, I'll do so from a
brand new repository.  Sorry for any confusion.

..mark
Reply | Threaded
Open this post in threaded view
|

Re: Re [Cygwin PATCH */9] tzcode resync -- for discussion only

Corinna Vinschen-2
On May 13 15:40, Mark Geisert wrote:

> I'm not absolutely sure yet but I think this patch set isn't complete.
> What's been posted is OK for discussion (on cygwin-developers?) but would
> need to be augmented if you're going to apply as-is.
>
> I had a git commit/revert mishap and these are recovered file versions.  I
> belatedly discovered there's no record in the patches of my creating
> directory winsup/cygwin/tzcode or of my deleting localtime.cc and
> tz_posixrules.h from winsup/cygwin in my local repository.
>
> When it becomes time to submit the final patch versions, I'll do so from a
> brand new repository.  Sorry for any confusion.

Patchset discussions should stay on cygwin-patches as part of the set.

Please resend the patchset in the current state on top of current git.
Please add a cover letter (git format-patch --cover-letter ...) and just
start the discussion yourself in the cover letter.  Note what you
think is missing from the patchset and what you think needs addition or
change, so we're vaguely on the same level as you :)


Thanks,
Corinna

--
Corinna Vinschen
Cygwin Maintainer
Reply | Threaded
Open this post in threaded view
|

Re: Re [Cygwin PATCH */9] tzcode resync -- for discussion only

Corinna Vinschen-2
On May 19 11:48, Corinna Vinschen wrote:

> On May 13 15:40, Mark Geisert wrote:
> > I'm not absolutely sure yet but I think this patch set isn't complete.
> > What's been posted is OK for discussion (on cygwin-developers?) but would
> > need to be augmented if you're going to apply as-is.
> >
> > I had a git commit/revert mishap and these are recovered file versions.  I
> > belatedly discovered there's no record in the patches of my creating
> > directory winsup/cygwin/tzcode or of my deleting localtime.cc and
> > tz_posixrules.h from winsup/cygwin in my local repository.
> >
> > When it becomes time to submit the final patch versions, I'll do so from a
> > brand new repository.  Sorry for any confusion.
>
> Patchset discussions should stay on cygwin-patches as part of the set.
>
> Please resend the patchset in the current state on top of current git.
> Please add a cover letter (git format-patch --cover-letter ...) and just
> start the discussion yourself in the cover letter.  Note what you
> think is missing from the patchset and what you think needs addition or
> change, so we're vaguely on the same level as you :)

Scratch that, I didn't see your v2 yet, sorry!


Corinna

--
Corinna Vinschen
Cygwin Maintainer