Proposed patch for cygport to fix homepage command

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Proposed patch for cygport to fix homepage command

Doug Henderson
Hi,

The "cygport <PN.cygport> homepage" command fails in two situations.

1. The default install location for Firefox 64 in WIn7 64 is

    "C:\Program Files\Mozilla Firefox\firefox.exe"

To use this from cygwin, it must be convert with "cygpath -u" and
results in a path name which includes spaces, and thus require
quoting. Cygport will use the BROWSER environment variable, when set,
but it does not quote the value everywhere it is used.


2. If the package does not include a HOMEPAGE variable, cygport
defaults to searching google for the program name, e.g.:

    "http://www.google.com/search?q=${ORIG_PN:-${PN}}"

however it does not quote the value everywhere it is used.


The attached patch quotes the path to the browser executable, and the
homepage URL at all locations where they are used.


HTH,

Doug

--
Doug Henderson, Calgary, Alberta, Canada - from gmail.com

cygport-0.24.1-2.src.patch (1K) Download Attachment
Loading...