[PATCH setup] Fix spinning after replace-on-reboot failure or skipped
- extracting a file failed AND --no-replaceonreboot was used
- OR, writing the .new file for replacing on reboot failed
we don't advance to the next file in the archive, so we just sit there,
trying the same operation repeatedly.
Yes, this seems to mean that --no-replaceonreboot never worked usefully.
Also advance to next file in extract_other error case.
- // don't mark this package as successfully installed
- error_in_this_package = true;
+ error_in_this_file = true;
@@ -642,6 +643,16 @@ Installer::installOne (packagemeta &pkgm, const packageversion &ver,
// We're done with this file
+ // if an error occured ...
+ if (error_in_this_file)
+ // skip to next file in archive
+ // don't mark this package as successfully installed
+ error_in_this_package = true;
progress (pkgfile->tell ());