[PATCH] fhandler_proc.cc:format_proc_cpuinfo add rdpru flag

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] fhandler_proc.cc:format_proc_cpuinfo add rdpru flag

Brian Inglis
rdpru flag is cpuid xfn 80000008 ebx bit 4 added in linux 5.5;
see AMD64 Architecture Programmer’s Manual Volume 3:
General-Purpose and System Instructions
https://www.amd.com/system/files/TechDocs/24594.pdf#page=329
and elsewhere in that document

---
 winsup/cygwin/fhandler_proc.cc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/winsup/cygwin/fhandler_proc.cc b/winsup/cygwin/fhandler_proc.cc
index 8c331f5f4..78a69703d 100644
--- a/winsup/cygwin/fhandler_proc.cc
+++ b/winsup/cygwin/fhandler_proc.cc
@@ -1255,6 +1255,7 @@ format_proc_cpuinfo (void *, char *&destbuf)
   ftcprint (features1,  0, "clzero");    /* clzero instruction */
   ftcprint (features1,  1, "irperf");       /* instr retired count */
   ftcprint (features1,  2, "xsaveerptr");   /* save/rest FP err ptrs */
+  ftcprint (features1,  4, "rdpru");    /* user level rd proc reg */
 /*  ftcprint (features1,  6, "mba"); */    /* memory BW alloc */
   ftcprint (features1,  9, "wbnoinvd");     /* wbnoinvd instruction */
 /*  ftcprint (features1, 12, "ibpb" ); */    /* ind br pred barrier */
--
2.21.0

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] fhandler_proc.cc:format_proc_cpuinfo add rdpru flag

Corinna Vinschen-2
On Jan 23 02:06, Brian Inglis wrote:
> rdpru flag is cpuid xfn 80000008 ebx bit 4 added in linux 5.5;
> see AMD64 Architecture Programmer’s Manual Volume 3:
                                   ^^^^^^^^^
This came over already broken.  No idea if that's a problem of
your MUA or of the mailing list software.  I fixed it to an
ordinary quote char locally.

> General-Purpose and System Instructions
> https://www.amd.com/system/files/TechDocs/24594.pdf#page=329
> and elsewhere in that document
>
> ---
>  winsup/cygwin/fhandler_proc.cc | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/winsup/cygwin/fhandler_proc.cc b/winsup/cygwin/fhandler_proc.cc
> index 8c331f5f4..78a69703d 100644
> --- a/winsup/cygwin/fhandler_proc.cc
> +++ b/winsup/cygwin/fhandler_proc.cc
> @@ -1255,6 +1255,7 @@ format_proc_cpuinfo (void *, char *&destbuf)
>    ftcprint (features1,  0, "clzero");    /* clzero instruction */
>    ftcprint (features1,  1, "irperf");       /* instr retired count */
>    ftcprint (features1,  2, "xsaveerptr");   /* save/rest FP err ptrs */
> +  ftcprint (features1,  4, "rdpru");    /* user level rd proc reg */
>  /*  ftcprint (features1,  6, "mba"); */    /* memory BW alloc */
>    ftcprint (features1,  9, "wbnoinvd");     /* wbnoinvd instruction */
>  /*  ftcprint (features1, 12, "ibpb" ); */    /* ind br pred barrier */
> --
> 2.21.0
Pushed.


Thanks,
Corinna

--
Corinna Vinschen
Cygwin Maintainer

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] fhandler_proc.cc:format_proc_cpuinfo add rdpru flag

Brian Inglis
On 2020-01-23 05:44, Corinna Vinschen wrote:
> On Jan 23 02:06, Brian Inglis wrote:
>> rdpru flag is cpuid xfn 80000008 ebx bit 4 added in linux 5.5;
>> see AMD64 Architecture Programmer’s Manual Volume 3:
>                                    ^^^^^^^^^
> This came over already broken.  No idea if that's a problem of
> your MUA or of the mailing list software.  I fixed it to an
> ordinary quote char locally.

Sorry, didn't notice that sneaky quote from the PDF title in UTF-8 "’".
Message source shows it's composed and sent in UTF-8 with:
        Content-Transfer-Encoding: 8bit
by:
        X-Mailer: git-send-email 2.21.0
but without encoding or charset headers, so added git [sendemail] *Encoding
config settings to avoid future issues by adding header (tested):
        Content-Type: text/plain; charset=UTF-8

--
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada

This email may be disturbing to some readers as it contains
too much technical detail. Reader discretion is advised.