[PATCH cygport] Handle meson configuration options containing spaces

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH cygport] Handle meson configuration options containing spaces

Jon TURNEY
Similarly to cygconf, cygmeson should protect configuration options
containing spaces from word splitting so that e.g. cygmeson
"-Dstring_option=foo bah" works as expected.

Signed-off-by: Jon Turney <[hidden email]>
---
 cygclass/meson.cygclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cygclass/meson.cygclass b/cygclass/meson.cygclass
index a3d7824..f1daf0d 100644
--- a/cygclass/meson.cygclass
+++ b/cygclass/meson.cygclass
@@ -88,7 +88,7 @@ cygmeson() {
  --localstatedir=${prefix%/usr}/var \
  --sysconfdir=${prefix%/usr}/etc \
  --buildtype=plain --wrap-mode=nodownload \
- ${crossargs} ${CYGMESON_ARGS} ${@} ${CHOST} \
+ ${crossargs} ${CYGMESON_ARGS} "${@}" ${CHOST} \
  || error "meson failed"
 }
 
--
2.17.0

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH cygport] Handle meson configuration options containing spaces

Yaakov Selkowitz
On 2018-05-13 13:38, Jon Turney wrote:
> Similarly to cygconf, cygmeson should protect configuration options
> containing spaces from word splitting so that e.g. cygmeson
> "-Dstring_option=foo bah" works as expected.
>
> Signed-off-by: Jon Turney <[hidden email]>
> ---
>   cygclass/meson.cygclass | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Merged.

--
Yaakov