[PATCH] Cygwin: pty: Remove close() call just before reopening slave.

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Cygwin: pty: Remove close() call just before reopening slave.

Takashi Yano
- After commit da4ee7d60b9ff0bcdc081609a4467adb428d58e6, the issue
  reported in https://www.cygwin.com/ml/cygwin/2020-01/msg00209.html
  occurs. This patch fixes the issue.
---
 winsup/cygwin/fhandler_tty.cc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
index 73aeff37f..35a48338f 100644
--- a/winsup/cygwin/fhandler_tty.cc
+++ b/winsup/cygwin/fhandler_tty.cc
@@ -1326,7 +1326,6 @@ fhandler_pty_slave::push_to_pcon_screenbuffer (const char *ptr, size_t len)
     {
       termios_printf ("GetConsoleMode failed, %E");
       /* Re-open handles */
-      this->close ();
       this->open (0, 0);
       /* Fix pseudo console window size */
       this->ioctl (TIOCSWINSZ, &get_ttyp ()->winsize);
--
2.21.0

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Cygwin: pty: Remove close() call just before reopening slave.

Corinna Vinschen-2
On Jan 23 20:34, Takashi Yano wrote:

> - After commit da4ee7d60b9ff0bcdc081609a4467adb428d58e6, the issue
>   reported in https://www.cygwin.com/ml/cygwin/2020-01/msg00209.html
>   occurs. This patch fixes the issue.
> ---
>  winsup/cygwin/fhandler_tty.cc | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
> index 73aeff37f..35a48338f 100644
> --- a/winsup/cygwin/fhandler_tty.cc
> +++ b/winsup/cygwin/fhandler_tty.cc
> @@ -1326,7 +1326,6 @@ fhandler_pty_slave::push_to_pcon_screenbuffer (const char *ptr, size_t len)
>      {
>        termios_printf ("GetConsoleMode failed, %E");
>        /* Re-open handles */
> -      this->close ();
>        this->open (0, 0);
>        /* Fix pseudo console window size */
>        this->ioctl (TIOCSWINSZ, &get_ttyp ()->winsize);
> --
> 2.21.0
Pushed.


Thanks,
Corinna

--
Corinna Vinschen
Cygwin Maintainer

signature.asc (849 bytes) Download Attachment