Quantcast

[PATCH 01/01] machine/_types.h: __blkcnt_t should be signed

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[PATCH 01/01] machine/_types.h: __blkcnt_t should be signed

Ray Donnelly
Hi,

Please review and consider applying the attached patch. The commit message is:

[1] states: "blkcnt_t and off_t shall be signed integer types."
This causes pacman to fail when the size requirement
of the net update operation is negative, instead it
calculated a huge positive number.

[1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_types.h.html

--

Best regards,

Ray.

0001-machine-_types.h-__blkcnt_t-should-be-signed.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH 01/01] machine/_types.h: __blkcnt_t should be signed

Corinna Vinschen-2
On Jul 14 16:37, Ray Donnelly wrote:

> Hi,
>
> Please review and consider applying the attached patch. The commit message is:
>
> [1] states: "blkcnt_t and off_t shall be signed integer types."
> This causes pacman to fail when the size requirement
> of the net update operation is negative, instead it
> calculated a huge positive number.
>
> [1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_types.h.html
Patch applied.


Thanks,
Corinna

--
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

signature.asc (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH 01/01] machine/_types.h: __blkcnt_t should be signed

Ray Donnelly
On Thu, Jul 14, 2016 at 6:12 PM, Corinna Vinschen
<[hidden email]> wrote:

> On Jul 14 16:37, Ray Donnelly wrote:
>> Hi,
>>
>> Please review and consider applying the attached patch. The commit message is:
>>
>> [1] states: "blkcnt_t and off_t shall be signed integer types."
>> This causes pacman to fail when the size requirement
>> of the net update operation is negative, instead it
>> calculated a huge positive number.
>>
>> [1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_types.h.html
>
> Patch applied.
>
>
> Thanks,
> Corinna
>

Many thanks Corinna.

> --
> Corinna Vinschen                  Please, send mails regarding Cygwin to
> Cygwin Maintainer                 cygwin AT cygwin DOT com
> Red Hat
Loading...