This is a reorganization of the previous patch contents to cut down on
extraneous material. It seems to be complete and could thus be applied
to a copy of the newlib-cygwin tree successfully for testing or review.
Methods of testing can be discussed by reply to this post, or on
cygwin-developers, whichever is most appropriate. I'm also open to other
strategies of implementation if this one seems risky or unattractive for
Modifies winsup/cygwin/Makefile.in to build localtime.o from items in
new winsup/cygwin/tzcode subdirectory. Removes existing localtime.cc
and tz_posixrules.h from winsup/cygwin as they are superseded by the
On May 18 22:02, Mark Geisert wrote:
> Add tz_posixrules.h with data generated from most recent Cygwin tzdata
> package. Establish localtime.cc as primarily a wrapper around a patched
> copy of localtime.c. See README for more information.
This is where -Wall -Werror is getting annoying. We should contemplate
to drop -Werror for localtime.cc, or better to drop certain warnings by
using `#pragma GCC diagnostic ignored "..." from within localtime.cc to
allow certain warnings to go unpunished.
I'm also not quite sure anymore why we use calloc instead of malloc
where malloc is sufficient for the original code. We should probably
just drop this (but better check every call).
These are just examples, but the idea is clear I guess. The less
changes in localtime.c, the better for maintenance.