Heads-up: G-B-S changes (bash, logging)

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Heads-up: G-B-S changes (bash, logging)

Igor Peshansky
To everyone who uses G-B-S:

I've just committed a change that turns off logging functionality in the
generic-build-script by default.  If you still want logs, please invoke
your scripts with the "with_logs" (or "--logs") flag, or insert a call to
enablelogging() before the option processing loop.  I've also fixed the
"wrong exit code when logging" bug, so logging should be safe to use even
for potentially failing builds.  Note that some bash-isms were needed to
make this work correctly, so the g-b-s is now a bash script (but since
Cygwin's sh is bash, this shouldn't be a problem).

Please test.  Comments and suggestions welcome.  Also, if you have g-b-s
patches pending, please resubmit against CVS HEAD.  Thanks,
        Igor
--
                                http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_    [hidden email] | [hidden email]
ZZZzz /,`.-'`'    -.  ;-;;,_ Igor Peshansky, Ph.D. (name changed!)
     |,4-  ) )-,_. ,\ (  `'-' old name: Igor Pechtchanski
    '---''(_/--'  `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte."
"But no -- you are no fool; you call yourself a fool, there's proof enough in
that!" -- Rostand, "Cyrano de Bergerac"
Reply | Threaded
Open this post in threaded view
|

Re: Heads-up: G-B-S changes (bash, logging)

Yitzchak Scott-Thoennes
On Sat, Jan 28, 2006 at 03:43:43PM -0500, Igor Peshansky wrote:
> I've just committed a change that turns off logging functionality in the
> generic-build-script by default.

Um, why?
Reply | Threaded
Open this post in threaded view
|

Re: Heads-up: G-B-S changes (bash, logging)

Igor Peshansky
On Sat, 28 Jan 2006, Yitzchak Scott-Thoennes wrote:

> On Sat, Jan 28, 2006 at 03:43:43PM -0500, Igor Peshansky wrote:
> > I've just committed a change that turns off logging functionality in
> > the generic-build-script by default.
>
> Um, why?

Because it's still in the testing phase, and because not everyone wants
logs in their packages (I don't, for example).  Since I also added both an
in-script and command-line control mechanism, it's easy enough to turn on.

The decision to turn the logs off by default was made after I tried to use
the g-b-s to build a package recently.  If enough people complain, I'll
add a symmetric mechanism for turning logging off and use that in my
packages instead.
        Igor
--
                                http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_    [hidden email] | [hidden email]
ZZZzz /,`.-'`'    -.  ;-;;,_ Igor Peshansky, Ph.D. (name changed!)
     |,4-  ) )-,_. ,\ (  `'-' old name: Igor Pechtchanski
    '---''(_/--'  `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte."
"But no -- you are no fool; you call yourself a fool, there's proof enough in
that!" -- Rostand, "Cyrano de Bergerac"